Don't ignore options diff in synthetics resource #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ignore the diff completely when options_list is set, which sounds like unwanted behavior. Closes #697
romainberger
previously approved these changes
Oct 14, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jirikuncar
reviewed
Oct 14, 2020
It's going to be tough because we ignore diffs on those particular fields in the tests. I'll have a look. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nmuesch
reviewed
Oct 19, 2020
| @@ -263,6 +263,23 @@ func TestAccDatadogSyntheticsTCPTest_Basic(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccDatadogSyntheticsTCPLegacyOptionsTest_Basic(t *testing.T) { | |||
There was a problem hiding this comment.
Does this test give us anything specific?
The other two look to cover the case of
- ensuring we can still set the old options
- ensuring that if you upgrade from old -> new, the old is no longer present
There was a problem hiding this comment.
Good point, updated a test instead. We do cover the 2 point.
nmuesch
previously approved these changes
Oct 19, 2020
nmuesch
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore the diff completely when options_list is set, which sounds
like unwanted behavior.
Closes #697