Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client to v2.10.0 + Bugfix for monitor tag removal on update #70

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Client to v2.10.0 + Bugfix for monitor tag removal on update #70

merged 2 commits into from
Jun 25, 2018

Conversation

MattHodge
Copy link
Contributor

  • Updated DataDog Client (go-datadog-api.v2) to version v2.10.0, which includeds this fix from release v2.8.1:
Monitor tags weren't being removed when the list of tags was empty

@MattHodge
Copy link
Contributor Author

MattHodge commented Jun 9, 2018 •
edited
Loading

Tagging @radeksimko or @tombuildsstuff I noticed you guys have been merging a few PR's lately. Can you take a peak?

@paultyng
Copy link

cc @masci and @gmmeyer

paultyng
paultyng approved these changes Jun 20, 2018
View reviewed changes
Copy link

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Code looks good to me, and a big thanks for adding acc test coverage.

gmmeyer
gmmeyer approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me as well! thank you very much for the PR! :)

@gmmeyer gmmeyer merged commit 75ac012 into DataDog:master Jun 25, 2018
@masci masci added this to the 1.0.4 milestone Jul 5, 2018
This was referenced Jul 5, 2018
Closed
Closed
nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this pull request Nov 3, 2018
@gmmeyer
Merge pull request DataDog#70 from MattHodge/master
f90a622 
Client to v2.10.0 + Bugfix for monitor tag removal on update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattHodge @paultyng @gmmeyer @masci