Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom_links support to dashboard widget definitions #696

Merged
merged 9 commits into from
Oct 12, 2020
Merged

Add custom_links support to dashboard widget definitions #696

merged 9 commits into from
Oct 12, 2020

Conversation

sighrobot
Copy link
Contributor

@sighrobot sighrobot commented Oct 8, 2020 •
edited
Loading

Resolves #557

@sighrobot sighrobot requested review from a team as code owners October 8, 2020 14:36
@sighrobot sighrobot force-pushed the sherz/add-custom-links-support branch from c574cee to 7424c26 Compare October 8, 2020 14:50
@nmuesch
Copy link
Contributor

nmuesch commented Oct 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

nmuesch
nmuesch previously approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.
@DataDog/dashboards if someone could take a pass here as well 🙇

@sighrobot sighrobot changed the title [VIZZ-973] Add custom_links support to dashboard widget definitions Add custom_links support to dashboard widget definitions Oct 8, 2020
@nmuesch
Copy link
Contributor

nmuesch commented Oct 8, 2020

Took a look at the AZP failure, looks like the errors are an unrelated 409 on an AWS test, and a known issue about dashboard deletion. This is good to merge once dashboards approves 🙂

@jbenais
Copy link
Contributor

jbenais commented Oct 9, 2020

Looks good to me for Dashboards! 👏
I would just recommend to update the Terraform documentation with the new custom_link field.

@therve therve force-pushed the sherz/add-custom-links-support branch from bc4331a to 1c0df12 Compare October 12, 2020 07:30
@therve
Copy link
Contributor

therve commented Oct 12, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit d6d9925 into master Oct 12, 2020
@therve therve deleted the sherz/add-custom-links-support branch October 12, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbenais jbenais jbenais left review comments

@therve therve therve approved these changes

@nmuesch nmuesch nmuesch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support custom_links in timeseries_definition
5 participants
@sighrobot @nmuesch @jbenais @therve @skarimo