Update table widget definition and request #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nmuesch
reviewed
Oct 6, 2020
| @@ -3297,6 +3297,10 @@ func getQueryTableDefinitionSchema() map[string]*schema.Schema { | |||
| Schema: getWidgetTimeSchema(), | |||
| }, | |||
| }, | |||
| "has_search_bar": { | |||
| Type: schema.TypeString, | |||
There was a problem hiding this comment.
No, this is a string enum ("always", "never", or "auto") – is there a way to specify an enum?
There was a problem hiding this comment.
Ahh ok thanks. You could do something like set a ValidateFunc with stringInSlice - https://github.com/hashicorp/terraform/blob/master/helper/validation/validation.go#L32 but I think its OK to just document the allowed fields too.
sighrobot
force-pushed
the
abe/table-widget-updates
branch
from
2468a44 to
4eb75b0
Compare
sighrobot
changed the title
therve
requested changes
Oct 9, 2020
sighrobot
force-pushed
the
abe/table-widget-updates
branch
from
c4ca78b to
57300d8
Compare
|
@therve this is passing now and docs updated. We should probably wait to merge until the upstream correction to the schema (for |
sighrobot
force-pushed
the
abe/table-widget-updates
branch
from
80f49dd to
c133987
Compare
|
/azp run |
therve
approved these changes
Oct 16, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new properties to the table widget definition and request