Add target_format property to the Logs attribute remapper
#682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinckama
force-pushed
the
vincent.roy/logs_pipelines/add_target_format
branch
from
7c27806 to
d89bc5a
Compare
vinckama
changed the title
target_format property to the Logs attribute remapper
-> target_format have to be lowercase
vinckama
force-pushed
the
vincent.roy/logs_pipelines/add_target_format
branch
from
18c1b10 to
a283a89
Compare
vinckama
force-pushed
the
vincent.roy/logs_pipelines/add_target_format
branch
from
a283a89 to
9fdb263
Compare
vinckama
force-pushed
the
vincent.roy/logs_pipelines/add_target_format
branch
from
2972184 to
0abc246
Compare
vinckama
added
documentation
new-resource
and removed
do-not-merge/WIP
txominpelu
reviewed
Oct 8, 2020
| @@ -185,6 +186,7 @@ The following arguments are supported: | |||
| - `source_type`: (Required) Defines where the sources are from (log `attribute` or `tag`). | |||
| - `target`: (Required) Final `attribute` or `tag` name to remap the sources. | |||
| - `target_type`: (Required) Defines if the target is a log `attribute` or `tag`. | |||
| - `target_format`: (Optional) If the target of the remapper is an attribute, try to cast the value to a new specific type. If the cast is not possible, the original type is kept. `string`, `integer`, or `double` are the possible types. | |||
There was a problem hiding this comment.
Maybe you can make it more explicit that users should only set the target_format if the target_type is an attribute. It's already said, but for this kind of valid / invalid values it's better to be super explicit and not being afraid of being repetitive.
There was a problem hiding this comment.
thank you for pointing this out
txominpelu
approved these changes
Oct 8, 2020
txominpelu
previously approved these changes
Oct 8, 2020
vinckama
force-pushed
the
vincent.roy/logs_pipelines/add_target_format
branch
from
d47f20e to
8649967
Compare
therve
requested changes
Oct 8, 2020
| - `preserve_source`: (Optional, default = false) Remove or preserve the remapped source element. | ||
| - `override_on_conflict`: (Optional, default = false) Override the target element if already set. | ||
| - `name`: (Optional) Name of the processor | ||
| - `is_enabled`: (Optional, default = false) If the processor is enabled or not. | ||
| - category_processor | ||
| - `target`: (Required) Name of the target attribute whose value is defined by the matching category. | ||
| - `target`: (Required) Name of the target attribute whose value is defined by the matching category.` |
There was a problem hiding this comment.
Looks like an unintended change?
vinckama
force-pushed
the
vincent.roy/logs_pipelines/add_target_format
branch
from
8649967 to
0d3f676
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
therve
approved these changes
Oct 8, 2020
|
Any idea when this might be released? This feature is exactly what I was hunting for in the docs. |
|
Hello, we'll release in the next few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add target_format to attribute remapper
related to PR