[APM/Dashboards] add apm_stats_query #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
anbnyc
force-pushed
the
alec.barrett/apm_stats_query
branch
from
55c3028 to
01cc1d4
Compare
anbnyc
commented
Sep 29, 2020
| if v, ok := terraformQuery["primary_tag"].(string); ok && len(v) != 0 { | ||
| datadogQuery.SetPrimaryTag(v) | ||
| } | ||
| if v, ok := terraformQuery["row_type"].(datadogV1.ApmStatsQueryRowType); ok && len(v) != 0 { |
There was a problem hiding this comment.
I was getting an error for terraformQuery["row_type"].(string) and I think this is the solution, but please let me know if there's a more correct way
There was a problem hiding this comment.
I think it might more make sense to do datadogQuery.SetRowType(datadogV1.ApmStatsQueryRowType(v)).
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
therve
requested changes
Sep 30, 2020
| if v, ok := terraformQuery["primary_tag"].(string); ok && len(v) != 0 { | ||
| datadogQuery.SetPrimaryTag(v) | ||
| } | ||
| if v, ok := terraformQuery["row_type"].(datadogV1.ApmStatsQueryRowType); ok && len(v) != 0 { |
There was a problem hiding this comment.
I think it might more make sense to do datadogQuery.SetRowType(datadogV1.ApmStatsQueryRowType(v)).
…raform-provider-datadog into alec.barrett/apm_stats_query
anbnyc
force-pushed
the
alec.barrett/apm_stats_query
branch
from
388aeb8 to
18ba8f3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
therve
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supporting a new query type in dashboards for APM data sources. This PR would allow users to import and create dashboards with this query using Terraform.
See https://github.com/DataDog/datadog-api-spec/pull/579 for API spec.