Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Add support for steps for browser tests #638

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

romainberger
Copy link
Member

@romainberger romainberger commented Aug 17, 2020

Add support for browser test steps for Synthetics

@romainberger romainberger requested a review from a team as a code owner August 17, 2020 13:28
@therve
Copy link
Contributor

therve commented Aug 17, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor nits.

datadog/resource_datadog_synthetics_test_.go Show resolved Hide resolved
datadog/resource_datadog_synthetics_test_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_synthetics_test_test.go Outdated Show resolved Hide resolved
docs/resources/synthetics.md Outdated Show resolved Hide resolved
@therve
Copy link
Contributor

therve commented Aug 17, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit 689eb20 into master Aug 20, 2020
@therve therve deleted the rberger/SYA-110/synthetics-steps-3 branch August 20, 2020 09:22
@chrismllr
Copy link

chrismllr commented Oct 12, 2020

Hey there, seeing this issue after updating to v2.13.0, believe it has to do with this PR:

error getting synthetics test: assertFileDownload is not a valid SyntheticsStepType:

Although, we have no steps defined in our terraform files yet.

@therve
Copy link
Contributor

therve commented Oct 13, 2020

Hey there, seeing this issue after updating to v2.13.0, believe it has to do with this PR:

error getting synthetics test: assertFileDownload is not a valid SyntheticsStepType:

Although, we have no steps defined in our terraform files yet.

Do you mind opening a new issue for tracking this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants