Ignore diff to start on downtime resource #597
Merged
+493
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
reviewed
Jul 24, 2020
datadog/resource_datadog_downtime.go
Outdated
| @@ -46,7 +46,7 @@ func resourceDatadogDowntime() *schema.Resource { | |||
| Optional: true, | |||
| DiffSuppressFunc: func(k, oldVal, newVal string, d *schema.ResourceData) bool { | |||
| _, startDatePresent := d.GetOk("start_date") | |||
| return startDatePresent | |||
| return startDatePresent || (newVal == "0" && oldVal != "0") | |||
There was a problem hiding this comment.
@therve can you add examples when the diff should (not) be supressed?
There was a problem hiding this comment.
Suggested change
| return startDatePresent || (newVal == "0" && oldVal != "0") | |
| // "start_date" is set or was previously set (oldVal != "0") and it is being removed (newVal == "0") | |
| return startDatePresent || (oldVal != "0" && newVal == "0") |
There was a problem hiding this comment.
I added a comment, let me know if it makes sense.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
If the start attributes generates a diff from a value to nothing, it means that the attribute was never set to being with. Let's ignore the diff in that case. Closes #507
therve
force-pushed
the
therve/diff-downtime-start
branch
from
1210ae1 to
08160f3
Compare
jirikuncar
previously approved these changes
Jul 27, 2020
jirikuncar
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the start attributes generates a diff from a value to nothing, it
means that the attribute was never set to being with. Let's ignore the
diff in that case.
Closes #507