Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added
indexes
field to the log_stream widget schema was being directly accessed, this PR first checks if it exists, adding a safety layer to prevent panics.Fixes #534
I was able to reproduce this by creating a dashboard with a logstream widget using the provider version 2.7.0 like so:
title = "Test Log Stream Dashboard" description = "Created using the Datadog provider in Terraform" layout_type = "free" is_read_only = false widget { log_stream_definition { logset = "19" query = "error" columns = ["core_host", "core_service", "tag_source"] } layout = { height = 36 width = 32 x = 5 y = 51 } } }
which leads to a terraform state not having
indexes
set. Then upgrading to 2.8.0 and running a terraform apply, which was trying to directly access this field and throwing an error on refreshing/reading existing resources.