Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack integration #67 #411

Closed
wants to merge 3 commits into from

Conversation

bewiwi
Copy link

@bewiwi bewiwi commented Feb 11, 2020

Add slack integration #67

Allow the possibility to manage slack integration.

Example:

# Create a new Datadog - Slack integration
resource "datadog_integration_slack" "foo1" {
	account = "slack_pro_account"
	url = "http:///myslack/url"
   
   channels {
	   channel_name = "#prod-outage"
	   transfer_all_user_comments = false       
   }

   channels {
	   channel_name = "#staging-outage"
	   transfer_all_user_comments = false       
   }
}

@bewiwi bewiwi marked this pull request as ready for review February 11, 2020 10:03
datadog/resource_datadog_integration_slack.go Outdated Show resolved Hide resolved
datadog/resource_datadog_integration_slack.go Outdated Show resolved Hide resolved
datadog/resource_datadog_integration_slack.go Outdated Show resolved Hide resolved
datadog/resource_datadog_integration_slack.go Outdated Show resolved Hide resolved
@bewiwi bewiwi force-pushed the feat/add_slack_integration branch from dba8ae7 to 880802b Compare February 26, 2020 14:29
@msuterski
Copy link

Thanks for adding this! We're about to move some of the manual maintenance to TF and this will help a lot.

What's the current status of this PR? Are there any plans to merge and release it any time soon?

@bkabrda
Copy link
Contributor

bkabrda commented Mar 13, 2020

Hey 👋 thanks a lot for sending the PR! What I'm concerned about here is a concern mentioned in [1] that we eventually had to fix for Pagerduty integration. In short, for Pagerduty integration there was no way to configure individual service objects (analogous to channels in the Slack integration) independently (from multiple TF configs spread across several repos). The path forward implemented in [2] isn't completely straightforward and I'd like to avoid it.

That said, the DD team responsible for this API currently has no plans to implement manipulating individual channels, so I guess we can go forward with the approach in this PR, while understanding the caveat mentioned above and bearing in mind that in future we might need to do the same thing we did for the Pagerduty integration. I'll do an in-depth review and hopefully we would get this merged before the next release.

[1] https://github.com/terraform-providers/terraform-provider-datadog/issues/75
[2] https://github.com/terraform-providers/terraform-provider-datadog/pull/237

@tonglil
Copy link

tonglil commented May 1, 2020

Any update on maybe giving this a review? :)

@therve
Copy link
Contributor

therve commented Jul 21, 2020

The integration team is pushing a proper slack channels management API. This should make the slack resource more manageable through terraform, so that we don't reproduce the issue we had with pagerduty. We'll keep you posted.

@ken5scal
Copy link

Can't wait for the functionality! Any update since the last time?

@JordanP
Copy link
Contributor

JordanP commented Dec 30, 2020

Small "up" here. Slack is soooo widely used and sooo needed :) Thanks !

@andymac4182
Copy link

andymac4182 commented Jan 30, 2021

@therve Thanks for that update. It looks like the new APIs are available. If that is the case any chance of this resource coming soon?

@tdewitt
Copy link

tdewitt commented Feb 10, 2021

Adding another "status update" comment. This would be a pretty great addition to our pipelines. Right now this is one of the manual prerequisites for new services and that means it's easy to miss.

@nmuesch nmuesch removed their request for review March 23, 2022 13:20
@bewiwi bewiwi closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants