Fix slo threshold warning value modified when storing the state #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en pointer value was nil
ghost
added
the
nmuesch
approved these changes
Oct 30, 2019
|
Any chance of getting a patch release for this, the bug makes the optional field not so optional as it prevents updating the resource... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of the warning field in the threshold object was set to
0instead of being omitted when the pointer value was nil.This raised an error when updating a service level objective resource, as the value of
warningmust always be greater than theslo.This error is not raised on creation of the resource because the warning field is only modified in the
resourceDatadogServiceLevelObjectiveReadfunction, modifying the state after the creation of the resource.