Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_user] Add computed attributes to datadog_user datasource #2787

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ecdatadog
Copy link
Contributor

It is the equivalent of #2786 but for the datadog_user datasource

@ecdatadog ecdatadog requested review from a team as code owners January 21, 2025 10:54
@ecdatadog ecdatadog marked this pull request as draft January 21, 2025 10:54
@ecdatadog ecdatadog changed the title [datadog_user] Add computed attributes to keep parity with datadog_users [datadog_user] Add computed attributes to datadog_user Jan 21, 2025
@ecdatadog ecdatadog changed the title [datadog_user] Add computed attributes to datadog_user [datadog_user] Add computed attributes to datadog_user datasource Feb 3, 2025
@ecdatadog ecdatadog marked this pull request as ready for review February 4, 2025 07:21
@ecdatadog ecdatadog requested a review from a team as a code owner February 4, 2025 07:21
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions from Docs and approved the PR.

@@ -31,6 +31,16 @@ data "datadog_user" "test" {

### Read-Only

- `created_at` (String) Creation time of the user (RFC3339 format).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `created_at` (String) Creation time of the user (RFC3339 format).
- `created_at` (String) The time when the user was created (RFC3339 format).

@@ -31,6 +31,16 @@ data "datadog_user" "test" {

### Read-Only

- `created_at` (String) Creation time of the user (RFC3339 format).
- `disabled` (Boolean) Whether the user is disabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `disabled` (Boolean) Whether the user is disabled.
- `disabled` (Boolean) Indicates whether the user is disabled.

- `email` (String) Email of the user.
- `handle` (String) Handle of the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `handle` (String) Handle of the user.
- `handle` (String) The user's handle.

- `email` (String) Email of the user.
- `handle` (String) Handle of the user.
- `icon` (String) URL of the user's icon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `icon` (String) URL of the user's icon.
- `icon` (String) The URL where the user's icon is located.

- `id` (String) The ID of this resource.
- `mfa_enabled` (Boolean) If user has MFA enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `mfa_enabled` (Boolean) If user has MFA enabled.
- `mfa_enabled` (Boolean) Indicates whether the user has enabled MFA.

- `id` (String) The ID of this resource.
- `mfa_enabled` (Boolean) If user has MFA enabled.
- `modified_at` (String) Time that the user was last modified (RFC3339 format).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `modified_at` (String) Time that the user was last modified (RFC3339 format).
- `modified_at` (String) The time at which the user was last updated (RFC3339 format).

- `name` (String) Name of the user.
- `service_account` (Boolean) Whether the user is a service account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `service_account` (Boolean) Whether the user is a service account.
- `service_account` (Boolean) Indicates whether the user is a service account.

- `service_account` (Boolean) Whether the user is a service account.
- `status` (String) Status of the user.
- `title` (String) Title of the user.
- `verified` (Boolean) Whether the user is verified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `verified` (Boolean) Whether the user is verified.
- `verified` (Boolean) Indicates whether the user is verified.

- `name` (String) Name of the user.
- `service_account` (Boolean) Whether the user is a service account.
- `status` (String) Status of the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `status` (String) Status of the user.
- `status` (String) The user's status.

- `name` (String) Name of the user.
- `service_account` (Boolean) Whether the user is a service account.
- `status` (String) Status of the user.
- `title` (String) Title of the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `title` (String) Title of the user.
- `title` (String) The user's title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants