[datadog_application_key] use plan modifiers for app keys #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaskara-dd
changed the title
amaskara-dd
changed the title
amaskara-dd
changed the title
nkzou
approved these changes
Jan 13, 2025
amaskara-dd
changed the title
|
@amaskara-dd Why is this needed if we already check whether the response from the API has a copy of the key here? Did you notice the key getting overwritten in practice? |
|
@jackakeller We noticed the overwrite when updating the name of the application key after creation. The check in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App keys are not returned by the API after creation, so we should save the previous state values to avoid the
Provider returned invalid result object after applyand overwrite of state value with nullTested by creating an application key and updating its name