[AZINTS-2487] Update Azure integration terraform to support metric filitering #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-edmonds-dd
approved these changes
Jan 6, 2025
ava-silver
reviewed
Jan 6, 2025
Comment on lines
+304
to
+310
| state.ResourceProviderConfigs = make([]*ResourceProviderConfigModel, len(resourceProviderConfigs)) | ||
| for i, resourceProviderConfig := range resourceProviderConfigs { | ||
| state.ResourceProviderConfigs[i] = &ResourceProviderConfigModel{ | ||
| Namespace: types.StringValue(resourceProviderConfig.GetNamespace()), | ||
| MetricsEnabled: types.BoolValue(resourceProviderConfig.GetMetricsEnabled()), | ||
| } | ||
| } |
There was a problem hiding this comment.
go best practices would be to do this as:
Suggested change
| state.ResourceProviderConfigs = make([]*ResourceProviderConfigModel, len(resourceProviderConfigs)) | |
| for i, resourceProviderConfig := range resourceProviderConfigs { | |
| state.ResourceProviderConfigs[i] = &ResourceProviderConfigModel{ | |
| Namespace: types.StringValue(resourceProviderConfig.GetNamespace()), | |
| MetricsEnabled: types.BoolValue(resourceProviderConfig.GetMetricsEnabled()), | |
| } | |
| } | |
| state.ResourceProviderConfigs = make([]*ResourceProviderConfigModel, 0, len(resourceProviderConfigs)) | |
| for i, resourceProviderConfig := range resourceProviderConfigs { | |
| state.ResourceProviderConfigs = append(state.ResourceProviderConfigs, &ResourceProviderConfigModel{ | |
| Namespace: types.StringValue(resourceProviderConfig.GetNamespace()), | |
| MetricsEnabled: types.BoolValue(resourceProviderConfig.GetMetricsEnabled()), | |
| } | |
| } |
| datadogDefinition.SetMetricsEnabledDefault(state.MetricsEnabledDefault.ValueBool()) | ||
| datadogDefinition.SetUsageMetricsEnabled(state.UsageMetricsEnabled.ValueBool()) | ||
|
|
||
| resourceProviderConfigsPayload := make([]datadogV1.ResourceProviderConfig, len(state.ResourceProviderConfigs)) |
There was a problem hiding this comment.
same comment here as above
| <a id="nestedatt--resource_provider_configs"></a> | ||
| ### Nested Schema for `resource_provider_configs` | ||
|
|
||
| Optional: |
There was a problem hiding this comment.
should these be optional? and could we add an example usage to the example terraform?
There was a problem hiding this comment.
do we want to add any additional validation about the ResourceProviderConfigs within terraform? or leave it all up to the API? im thinking probably the latter but wanna make sure we've considered it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following options: