Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_integration_aws_available_namespaces] Create AWS Integrations V2 datasources datadog_integration_aws_available_logs_services/namespaces #2709

Merged
merged 11 commits into from
Dec 17, 2024
Merged

[datadog_integration_aws_available_namespaces] Create AWS Integrations V2 datasources datadog_integration_aws_available_logs_services/namespaces #2709

merged 11 commits into from
Dec 17, 2024

Conversation

ktmq
Copy link
Contributor

@ktmq ktmq commented Dec 9, 2024 •
edited
Loading

Adds data sources using AWS Integrations V2 API:

  • datadog_integration_aws_available_logs_services to replace v1 datadog_integration_aws_logs_services data source
  • datadog_integration_aws_available_namespaces to replace v1 datadog_integration_aws_namespace_rules data source

Adds docs on datadog_integration_aws_account fields to reference using these new data sources for allowed values.

@ktmq ktmq requested review from a team as code owners December 9, 2024 17:43
@ktmq ktmq requested a review from a team as a code owner December 13, 2024 22:33
@ktmq ktmq changed the title Add AWS Integrations V2 datasources [datadog_integration_aws_available_logs_services, datadog_integration_aws_available_namespaces] Create AWS Integrations V2 datasources Dec 13, 2024
@ktmq ktmq changed the title [datadog_integration_aws_available_logs_services, datadog_integration_aws_available_namespaces] Create AWS Integrations V2 datasources [datadog_integration_aws_available_namespaces] Create AWS Integrations V2 datasources datadog_integration_aws_available_logs_services/namespaces Dec 13, 2024
HantingZhang2
HantingZhang2 previously approved these changes Dec 16, 2024
View reviewed changes
brett0000FF
brett0000FF previously approved these changes Dec 16, 2024
View reviewed changes
Copy link

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comment/suggestion. Thanks!

docs/resources/integration_aws_account.md Show resolved Hide resolved
docs/data-sources/integration_aws_available_namespaces.md Outdated Show resolved Hide resolved
docs/data-sources/integration_aws_available_namespaces.md Outdated Show resolved Hide resolved
@ktmq ktmq dismissed stale reviews from brett0000FF and HantingZhang2 via cc43e78 December 16, 2024 15:54
@HantingZhang2 HantingZhang2 merged commit 33b80ca into master Dec 17, 2024
12 checks passed
@HantingZhang2 HantingZhang2 deleted the katie.mckew/awscustexp-138-aws-v2-datasources branch December 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF approved these changes

@saleelsaptarshi-dd saleelsaptarshi-dd saleelsaptarshi-dd approved these changes

@HantingZhang2 HantingZhang2 HantingZhang2 approved these changes

Assignees
No one assigned
Labels
changelog/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ktmq @HantingZhang2 @saleelsaptarshi-dd @brett0000FF @amaskara-dd