Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_api_key] Add deprecation warning for importing datadog_api_key resources #2543

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

tyjet
Copy link
Contributor

@tyjet tyjet commented Aug 28, 2024

Add a new deprecation warning that Import will no longer be supported for application keys.

datadog_api_key.ddiner_test: Preparing import... [id=b4371e76-3361-4034-9b48-f15e7514587f]
datadog_api_key.ddiner_test: Refreshing state... [id=b4371e76-3361-4034-9b48-f15e7514587f]

Terraform will perform the following actions:

  # datadog_api_key.ddiner_test will be imported
    resource "datadog_api_key" "ddiner_test" {
        id   = "b4371e76-3361-4034-9b48-f15e7514587f"
        key  = (sensitive value)
        name = "ddiner-test"
    }

Plan: 1 to import, 0 to add, 0 to change, 0 to destroy.
╷
│ Warning: Deprecated
│
│ The import functionality for datadog_api_key resources is deprecated and will be removed in a future release with prior
│ notice. Securely store your API keys using a secret management system or use the datadog_api_key resource to create and
│ manage new API keys.
╵

@tyjet tyjet marked this pull request as ready for review August 28, 2024 15:02
@tyjet tyjet requested review from a team as code owners August 28, 2024 15:02
@tyjet tyjet changed the title Add deprecation warning for importing datadog_api_key resources. [datadog_api_key] Add deprecation warning for importing datadog_api_key resources. Aug 28, 2024
@tyjet tyjet changed the title [datadog_api_key] Add deprecation warning for importing datadog_api_key resources. [datadog_api_key] Add deprecation warning for importing datadog_api_key resources Aug 28, 2024
@jack-edmonds-dd
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 29, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 1m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit cbaf1ca into master Aug 29, 2024
22 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the david.diner/CRED-621 branch August 29, 2024 18:29
@dhduvall
Copy link

I'm curious about the reasoning behind this (and #2468). If the resource itself is not being removed, then the key itself still can end up in the state, so i doesn't seem to be about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants