[datadog_application_key] Stop overwriting key values in state when the API omits the key #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackakeller
force-pushed
the
jackakeller/only-update-key-attribute-if-present-application-key-resources
branch
from
6ffb740 to
937ed00
Compare
jackakeller
changed the title
jackakeller
changed the title
…nt in API response
jackakeller
force-pushed
the
jackakeller/only-update-key-attribute-if-present-application-key-resources
branch
from
937ed00 to
1eb5e9e
Compare
jackakeller
changed the title
jackakeller
changed the title
tyjet
approved these changes
Jul 10, 2024
adityab-datadog
approved these changes
Jul 10, 2024
nkzou
approved these changes
Jul 11, 2024
nkzou
changed the title
nkzou
deleted the
jackakeller/only-update-key-attribute-if-present-application-key-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating or importing application key resources, if the Datadog API does not include the optional computed
keyfield, then the field is overwritten with an empty string in terraform state. The key is immutable so it does not need to be updated once it has been initially set.Added a check to ensure the field is set before writing it into the response.
Tested manually via integration test against API responses with and without the key field. Updated unit test to match new behavior and not depend on the API returning an optional field.