Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] support json schema assertion in api and multi test #2437

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

etnbrd
Copy link
Contributor

@etnbrd etnbrd commented Jun 13, 2024

This PR implements the support for JSON Schema validation of the body, for API and Multi-API synthetic tests.

@etnbrd etnbrd self-assigned this Jun 13, 2024
@etnbrd etnbrd force-pushed the etnbrd/SYNTH-13362/jsonschema-assertion branch from fac9883 to cb69cc2 Compare June 13, 2024 09:50
@etnbrd etnbrd marked this pull request as ready for review June 13, 2024 09:53
@etnbrd etnbrd requested review from a team as code owners June 13, 2024 09:53
Drarig29
Drarig29 previously approved these changes Jun 13, 2024
Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

datadog/resource_datadog_synthetics_test_.go Outdated Show resolved Hide resolved
datadog/resource_datadog_synthetics_test_.go Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
HantingZhang2
HantingZhang2 previously approved these changes Jun 13, 2024
@etnbrd etnbrd dismissed stale reviews from HantingZhang2 and Drarig29 via 77e6fbd June 13, 2024 11:44
@etnbrd etnbrd requested review from Drarig29 and HantingZhang2 June 13, 2024 12:05
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs!

@HantingZhang2 HantingZhang2 merged commit dd566a5 into master Jun 13, 2024
10 checks passed
@HantingZhang2 HantingZhang2 deleted the etnbrd/SYNTH-13362/jsonschema-assertion branch June 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants