Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_synthetics_test] Fix docs for browser_step.params.email #2425

Merged
merged 2 commits into from
Jun 7, 2024
Merged

[datadog_synthetics_test] Fix docs for browser_step.params.email #2425

merged 2 commits into from
Jun 7, 2024

Conversation

fabrideci
Copy link
Contributor

It was not specified the parameter browser_step.params.email must be a JSON encoded string, as I discovered on my own.

@fabrideci fabrideci requested review from a team as code owners June 5, 2024 16:29
buraizu
buraizu previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, approving with one minor change requested

docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
@nkzou nkzou requested review from a team as code owners June 5, 2024 20:59
Drarig29
Drarig29 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@Drarig29 Drarig29 changed the title Specify right type for datadog_synthetics_test.browser_step.params.email [datadog_synthetics_test] Specify right type for browser_step.params.email Jun 7, 2024
@Drarig29 Drarig29 changed the title [datadog_synthetics_test] Specify right type for browser_step.params.email [datadog_synthetics_test] Fix docs for browser_step.params.email Jun 7, 2024
@nkzou nkzou merged commit 61f3746 into DataDog:master Jun 7, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkzou nkzou nkzou approved these changes

@Drarig29 Drarig29 Drarig29 approved these changes

@buraizu buraizu buraizu left review comments

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabrideci @Drarig29 @nkzou @buraizu