Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] support file upload for api test #2422

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

etnbrd
Copy link
Contributor

@etnbrd etnbrd commented Jun 5, 2024

This PR implements the upload file feature for API tests (and steps) for the terraform provider.

⚠️ One gotcha is that we aren't sure how to upload the file only when the file content is updated, because it implies to know when the terraform config was updated locally, which isn't trivial and might lead to more edge cases than expected.
Instead, we accept re-uploading the file every time the test is updated.

@etnbrd etnbrd requested review from a team as code owners June 5, 2024 09:16
@etnbrd etnbrd force-pushed the etnbrd/SYNTH-12798/file-upload-api-test branch from d8588f7 to 6eb536a Compare June 5, 2024 09:16
@etnbrd etnbrd changed the title [SYNTH-12798] support file upload for api test [synthetics] support file upload for api test Jun 5, 2024
@etnbrd etnbrd changed the title [synthetics] support file upload for api test [datadog_synthetics_test] support file upload for api test Jun 5, 2024
@etnbrd etnbrd requested a review from a team as a code owner June 5, 2024 09:30
Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@HantingZhang2 HantingZhang2 merged commit f544ec3 into master Jun 7, 2024
10 checks passed
@HantingZhang2 HantingZhang2 deleted the etnbrd/SYNTH-12798/file-upload-api-test branch June 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants