Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Ensure tags are non-empty and castable #2393

Merged
merged 2 commits into from
May 7, 2024

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented May 3, 2024

SSIA, bugfix in response to customer ticket

@nkzou nkzou requested review from a team as code owners May 3, 2024 18:52
Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean the tag will be silently ignored if not castable to string?

Can you give an example of something non-castable that the user was passing?

@nkzou nkzou changed the title [datadog_synthetics_test] Make sure tags are castable to string [datadog_synthetics_test] Ensure tags are non-empty and castable May 7, 2024
Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For context, a customer had tags = ["foo:bar", "", "hello:world"] and it was returning the same error as #1795:

interface {} is nil, not string

@nkzou nkzou merged commit d671d9c into master May 7, 2024
11 checks passed
@nkzou nkzou deleted the kevinzou/synthetics_nil_tag branch May 7, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants