Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_security_monitoring_suppression] Fix error handling when updating suppression payload #2383

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

clementgbcn
Copy link
Contributor

@clementgbcn clementgbcn commented Apr 24, 2024

We discovered that providing an empty expiration date/badly formatted expiration date led to a kernel panic:
invalid memory address or nil pointer dereference.

It was due to a missing return after getting an error.

After adding this change, we did a local test to check that the error was properly handled.

@clementgbcn clementgbcn requested a review from a team as a code owner April 24, 2024 11:27
@clementgbcn clementgbcn force-pushed the cgc/handle-empty-expiration-date-in-suppression branch from 25e7156 to a8f6131 Compare April 24, 2024 11:33
@clementgbcn clementgbcn force-pushed the cgc/handle-empty-expiration-date-in-suppression branch from a8f6131 to 051cf9a Compare April 24, 2024 13:24
@clementgbcn clementgbcn changed the title [datadog_security_monitoring_suppression] Handle an empty string for expiration date [datadog_security_monitoring_suppression] Fix error handling when updating suppression payload Apr 24, 2024
Copy link
Contributor

@pietrodll pietrodll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@clementgbcn
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@nkzou nkzou merged commit 82f9ffd into master Apr 24, 2024
15 of 18 checks passed
@nkzou nkzou deleted the cgc/handle-empty-expiration-date-in-suppression branch April 24, 2024 14:14
@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2024

🚂 MergeQueue

This pull request was merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants