[datadog_sensitive_data_scanner_rule] Add priority level in rules #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtrieu
previously approved these changes
Apr 22, 2024
Co-authored-by: Rosa Trieu <[email protected]>
vinckama
previously approved these changes
Apr 23, 2024
skarimo
changed the title
skarimo
reviewed
Apr 23, 2024
Remove changelog Co-authored-by: skarimo <[email protected]>
skarimo
previously approved these changes
Apr 23, 2024
rtrieu
reviewed
Apr 23, 2024
Co-authored-by: Rosa Trieu <[email protected]>
|
Sorry @rtrieu I accepted your changed but the script to generated docs overrides it. I think it is good know |
|
Hi @trosenblatt I think it did it again 😅 |
|
@rtrieu what do you mean it did it again ? I replaced the is with being. Is there anything else ? |
|
Hi @trosenblatt I meant that it looks like the script overrode my suggestion and review. I will approve again now! |
skarimo
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA_TICKET This enable support for priority field in SDS Rules in datadog terraform provider