[datadog_security_monitoring_suppression] Add data_exclusion_query #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtrieu
requested changes
Apr 12, 2024
pietrodll
force-pushed
the
pietrodll/security-monitoring-suppressions-data-exclusion
branch
from
f7a3fe1 to
3283355
Compare
nkzou
approved these changes
Apr 18, 2024
clementgbcn
approved these changes
Apr 19, 2024
nkzou
deleted the
pietrodll/security-monitoring-suppressions-data-exclusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
data_exclusion_queryfield todatadog_security_monitoring_suppressionschema. Also makessuppression_queryoptional instead of required. The backend API ensures that eitherdata_exclusion_queryorsuppression_queryis defined.This requires bumping the Go API client, which required some unrelated code changes.