Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_security_monitoring_rule] Explicitly remove filters when none remain in config #2334

Merged
merged 4 commits into from
Mar 22, 2024
Merged

[datadog_security_monitoring_rule] Explicitly remove filters when none remain in config #2334

merged 4 commits into from
Mar 22, 2024

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Mar 21, 2024

Resolves #2330

@nkzou nkzou requested review from a team as code owners March 21, 2024 20:28
pietrodll
pietrodll previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@pietrodll pietrodll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

skarimo
skarimo reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@skarimo skarimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would be a cleaner to just always call buildPayloadFilters and initialize and empty list make([]string, 0)

skarimo
skarimo previously approved these changes Mar 22, 2024
View reviewed changes
@nkzou nkzou dismissed stale reviews from skarimo and pietrodll via 45da6cc March 22, 2024 15:27
@nkzou nkzou merged commit 0968ae1 into master Mar 22, 2024
10 checks passed
@nkzou nkzou deleted the kevinzou/remove_last_filter branch March 22, 2024 19:27
@skarimo skarimo mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

@pietrodll pietrodll pietrodll left review comments

Assignees
No one assigned
Labels
changelog/bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to remove suppression filters from datadog_security_monitoring_rule
3 participants
@nkzou @pietrodll @skarimo