[datadog_csm_threats_agent_rules] Add a by resource lock to prevent 409s #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malo10LeGoff
changed the title
Malo10LeGoff
changed the title
jgrillo-ddog
previously approved these changes
Mar 20, 2024
| @@ -117,6 +122,9 @@ func (r *csmThreatsAgentRuleResource) Read(ctx context.Context, request resource | |||
| return | |||
| } | |||
|
|
|||
| csmThreatsMutex.Lock() | |||
There was a problem hiding this comment.
Do we need to acquire the lock on Read?
skarimo
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR, added the new csm_agent_threats resource. Thing is, sometimes we got 409s from the backend because of requests accessing the same resource.
This PR removes this possibility by introducing a lock by resource.