Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_sensitive_data_scanner] Handle new included_keyword_configuration attribute in scanning rule #2238

Merged
merged 22 commits into from
Jan 29, 2024

Conversation

artslidd
Copy link
Contributor

@artslidd artslidd commented Jan 11, 2024

Description

After adding the new included_keyword_configuration attribute to the public API of sensitive data scanner (https://github.com/DataDog/datadog-api-spec/pull/2598), we would like to have the Datadog terraform provider package handle it.

This PR adds support for this new attribute

@artslidd artslidd marked this pull request as ready for review January 22, 2024 08:09
@artslidd artslidd requested review from a team as code owners January 22, 2024 08:09
@artslidd artslidd changed the title Handle new included_keyword_configuration attribute in scanning rule [datadog_sensitive_data_scanner] Handle new included_keyword_configuration attribute in scanning rule Jan 22, 2024
Copy link
Contributor

@vinckama vinckama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments

Prepager
Prepager previously approved these changes Jan 22, 2024
alexianelaude
alexianelaude previously approved these changes Jan 22, 2024
Copy link
Contributor

@vinckama vinckama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two minor comments, otherwise it looks good to me.

docs/resources/sensitive_data_scanner_rule.md Outdated Show resolved Hide resolved
vinckama
vinckama previously approved these changes Jan 23, 2024
Copy link
Contributor

@vinckama vinckama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two minor comments, otherwise it looks good to me.

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions!

docs/resources/sensitive_data_scanner_rule.md Outdated Show resolved Hide resolved
docs/resources/sensitive_data_scanner_rule.md Outdated Show resolved Hide resolved
@artslidd artslidd dismissed stale reviews from vinckama and alexianelaude via 059ea1d January 24, 2024 08:17
maycmlee
maycmlee previously approved these changes Jan 24, 2024
@nkzou nkzou merged commit c4d233c into master Jan 29, 2024
9 checks passed
@nkzou nkzou deleted the artslidd/LOGSAC-323-new-keyword branch January 29, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants