-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog_sensitive_data_scanner] Handle new included_keyword_configuration
attribute in scanning rule
#2238
Conversation
included_keyword_configuration
attribute in scanning ruleincluded_keyword_configuration
attribute in scanning rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two minor comments, otherwise it looks good to me.
examples/resources/datadog_sensitive_data_scanner_rule/resource.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two minor comments, otherwise it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions!
Co-authored-by: May Lee <[email protected]>
Co-authored-by: May Lee <[email protected]>
Description
After adding the new
included_keyword_configuration
attribute to the public API of sensitive data scanner (https://github.com/DataDog/datadog-api-spec/pull/2598), we would like to have the Datadog terraform provider package handle it.This PR adds support for this new attribute