Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_gcp_sts] Avoid initializing attributes using WithDefault() #2236

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Jan 10, 2024

WithDefault() sets default values for fields which have a default value on the client side. Lets remove this and fallback on backend default. The backend behavior should be the same as the client with the perk of not overriding existing user configs on update for unsupported fields.

@skarimo skarimo requested review from a team as code owners January 10, 2024 20:28
@skarimo skarimo requested a review from dtru-ddog January 10, 2024 20:28
@nkzou nkzou merged commit 2a4943b into master Jan 10, 2024
11 checks passed
@nkzou nkzou deleted the sherz/gcp-sts-remove-with-default branch January 10, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants