[datadog_integration_azure] Add resource_collection_enabled #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection-new-sdk
ava-silver
commented
Dec 8, 2023
docs/resources/dashboard.md
Outdated
There was a problem hiding this comment.
autogenerated by make docs, not my change
urseberry
reviewed
Dec 8, 2023
docs/resources/integration_azure.md
Outdated
Comment on lines
44
to
45
| - `cspm_enabled` (Boolean) When enabled, Datadog’s Cloud Security Management product will scan resource configurations monitored by this app registration. | ||
| Note: This requires `resource_collection_enabled` to be set to true. Defaults to `false`. |
There was a problem hiding this comment.
Suggested change
| - `cspm_enabled` (Boolean) When enabled, Datadog’s Cloud Security Management product will scan resource configurations monitored by this app registration. | |
| Note: This requires `resource_collection_enabled` to be set to true. Defaults to `false`. | |
| - `cspm_enabled` (Boolean) When enabled, Datadog’s Cloud Security Management product scans resource configurations monitored by this app registration. | |
| **Note:** This parameter requires `resource_collection_enabled` to be set to true. `resource_collection_enabled` defaults to `false`, so change it to `true` if you enable `cspm_enabled`. |
There was a problem hiding this comment.
the Defaults to false. part is autogenerated at the end, however the resource_collection_enabled is optional, the only constraint set by the API is that if cspm_enabled is true, then resource_collection_enabled cannot be explicitly set to false.
would something like the following work?
**Note:** This parameter cannot be set to true if `resource_collection_enabled` is explicitly set to false, as this feature depends on resource collection. Defaults to `false`.
urseberry
reviewed
Dec 8, 2023
docs/resources/integration_azure.md
Outdated
| @@ -41,9 +41,11 @@ resource "datadog_integration_azure" "sandbox" { | |||
| - `app_service_plan_filters` (String) This comma-separated list of tags (in the form `key:value,key:value`) defines a filter that Datadog uses when collecting metrics from Azure App Service Plans. Only App Service Plans that match one of the defined tags are imported into Datadog. The rest, including the apps and functions running on them, are ignored. This also filters the metrics for any App or Function running on the App Service Plan(s). Defaults to `""`. | |||
| - `automute` (Boolean) Silence monitors for expected Azure VM shutdowns. Defaults to `false`. | |||
| - `container_app_filters` (String) This comma-separated list of tags (in the form `key:value,key:value`) defines a filter that Datadog uses when collecting metrics from Azure Container Apps. Only Container Apps that match one of the defined tags are imported into Datadog. Defaults to `""`. | |||
| - `cspm_enabled` (Boolean) Enable Cloud Security Management Misconfigurations for your organization. Defaults to `false`. | |||
| - `cspm_enabled` (Boolean) When enabled, Datadog’s Cloud Security Management product will scan resource configurations monitored by this app registration. | |||
There was a problem hiding this comment.
Suggested change
| - `cspm_enabled` (Boolean) When enabled, Datadog’s Cloud Security Management product will scan resource configurations monitored by this app registration. | |
| - `cspm_enabled` (Boolean) When enabled, Datadog’s Cloud Security Management product scans resource configurations monitored by this app registration. |
Updated suggestion based on our conversation.
urseberry
approved these changes
Dec 11, 2023
parsons90
approved these changes
Dec 11, 2023
skarimo
approved these changes
Dec 12, 2023
skarimo
deleted the
ava.silver/azints-1971/add-azure-resource-collection-new-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Resource Collection field (
resource_collection_enabled) to the Azure Integration.The new field is optional with no default, as it interacts with
cspm_enabledso we want to let the API dictate the behavior when not specified by not providing a default value here.