Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data_source_datadog_synthetics_test] Allow datasource to take a test URL as well as id #1993

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

Cgg
Copy link
Contributor

@Cgg Cgg commented Jul 5, 2023

To fetch a test with id foo, one can now use https://app.datadoghq.com/synthetics/details/foo as well as just foo. This makes for a better devx when using the provider, as users can cmd-click to see the test on the web-app from their code editor.

@Cgg Cgg requested review from a team as code owners July 5, 2023 11:17
@Cgg Cgg force-pushed the clement.geiger/s8s-id-url branch from 56c1312 to 6f0187a Compare July 5, 2023 11:29
@Cgg Cgg changed the title [data_source_datadog_synthetics_test]✨Allow s8s datasource to take a test URL as well as id [data_source_datadog_synthetics_test] Allow s8s datasource to take a test URL as well as id Jul 5, 2023
AlaricCalmette
AlaricCalmette previously approved these changes Jul 5, 2023
AlaricCalmette
AlaricCalmette previously approved these changes Jul 5, 2023
therve
therve previously approved these changes Jul 5, 2023
@therve therve changed the title [data_source_datadog_synthetics_test] Allow s8s datasource to take a test URL as well as id [data_source_datadog_synthetics_test] Allow datasource to take a test URL as well as id Jul 5, 2023
AlaricCalmette
AlaricCalmette previously approved these changes Jul 5, 2023
@Cgg Cgg dismissed stale reviews from AlaricCalmette and therve via 677ccdb July 5, 2023 13:38
@nkzou nkzou merged commit 18d4cb4 into master Jul 5, 2023
@nkzou nkzou deleted the clement.geiger/s8s-id-url branch July 5, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants