Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_integration_gcp] Mark resource as deprecated #1965

Merged
merged 4 commits into from
Jun 13, 2023
Merged

[datadog_integration_gcp] Mark resource as deprecated #1965

merged 4 commits into from
Jun 13, 2023

Conversation

joshhuie
Copy link
Contributor

@joshhuie joshhuie commented Jun 13, 2023 •
edited
Loading

Updates the GCP Integration Terraform Resource. We want to mark it as deprecated because of the newly created gcp_sts resource.

@joshhuie joshhuie added the do-not-merge/WIP Do not merge this PR label Jun 13, 2023
@joshhuie joshhuie requested review from a team as code owners June 13, 2023 17:25
@joshhuie joshhuie requested a review from a team as a code owner June 13, 2023 17:31
@nkzou nkzou changed the title mark resource as deprecated [datadog_integration_gcp] Mark resource as deprecated Jun 13, 2023
graybjones
graybjones approved these changes Jun 13, 2023
View reviewed changes
Copy link

@graybjones graybjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshhuie joshhuie removed the do-not-merge/WIP Do not merge this PR label Jun 13, 2023
@joshhuie joshhuie merged commit 1b22787 into master Jun 13, 2023
@joshhuie joshhuie deleted the josh.huie/mark_old_gcp_integration_as_deprecated branch June 13, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graybjones graybjones graybjones approved these changes

@nkzou nkzou nkzou approved these changes

Assignees
No one assigned
Labels
changelog/note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshhuie @nkzou @graybjones