Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Handle both example and secure missing from variables #1959

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

therve
Copy link
Contributor

@therve therve commented Jun 9, 2023

If the example is not set on a test config variable, it gets the secure field unconditionally and it can crash. This fixes it by checking the boolean cast properly.

Fixes #1958

… variables

If the example is not set on a test config variable, it gets the secure
field unconditionally and it can crash. This fixes it by checking the
boolean cast properly.

Fixes #1958
@therve therve requested review from a team as code owners June 9, 2023 07:07
@therve therve enabled auto-merge (squash) June 9, 2023 19:56
@therve therve disabled auto-merge June 12, 2023 06:56
@therve therve merged commit ef657c8 into master Jun 12, 2023
@therve therve deleted the therve/fix-synthetics-var-error branch June 12, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in synthetic test variable handling
2 participants