Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_synthetics_test] Remove required from jsonpath and xpath targetvalue fields #1880

Merged
merged 2 commits into from
Apr 26, 2023
Merged

[datadog_synthetics_test] Remove required from jsonpath and xpath targetvalue fields #1880

merged 2 commits into from
Apr 26, 2023

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Apr 19, 2023

Some operators, for example isUndefined don't use the targetvalue field, but the field is marked as required in the terraform schema. This PR removes the required flag.

@nkzou nkzou requested review from a team as code owners April 19, 2023 20:39
@nkzou nkzou requested a review from a team as a code owner April 19, 2023 20:42
@nkzou nkzou merged commit 65ebcb8 into master Apr 26, 2023
@nkzou nkzou deleted the kevinzou/synthetics_jsonpath_targetvalue_optional branch April 26, 2023 14:02
@nkzou nkzou mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt approved these changes

@romainberger romainberger romainberger approved these changes

Assignees
No one assigned
Labels
changelog/bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkzou @romainberger @cswatt