Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_monitor] Fix dropped hour_starts field when value is zero #1878

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Apr 19, 2023

There's no way to distinguish between zero values and unset values in the terraform plugin sdk, but as a workaround we can check if day_starts and month_starts are both unset since the zero value isn't valid for either and they also conflict with hour_starts in the API.

Closes #1871

@nkzou nkzou requested review from a team as code owners April 19, 2023 14:50
@nkzou nkzou merged commit db5c00e into master Apr 19, 2023
@nkzou nkzou deleted the kevinzou/monitor_scheduling_zero_value branch April 19, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduling_options has problem with "0" value
2 participants