Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_logs_custom_pipeline] Add reference table logs processor #1800

Merged
merged 5 commits into from
Mar 17, 2023
Merged

[datadog_logs_custom_pipeline] Add reference table logs processor #1800

merged 5 commits into from
Mar 17, 2023

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Mar 3, 2023 •
edited
Loading

SSIA. Resolves #1589 and #1098

@nkzou nkzou requested review from a team as code owners March 3, 2023 22:09
@nkzou nkzou requested a review from a team as a code owner March 3, 2023 22:12
@nkzou nkzou added the do-not-merge/WIP Do not merge this PR label Mar 3, 2023
@nkzou nkzou removed the do-not-merge/WIP Do not merge this PR label Mar 6, 2023
rtrieu
rtrieu previously approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vinckama
vinckama previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@vinckama vinckama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one comment

docs/resources/logs_custom_pipeline.md Outdated Show resolved Hide resolved
@nkzou nkzou dismissed stale reviews from vinckama, skarimo, and rtrieu via d317b76 March 17, 2023 13:29
@nkzou nkzou merged commit 19ed617 into master Mar 17, 2023
@nkzou nkzou deleted the kevinzou/ReferenceTableLogsLookupProcessor branch March 17, 2023 17:20
@nkzou nkzou mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

@rtrieu rtrieu rtrieu left review comments

@vinckama vinckama vinckama left review comments

Assignees
No one assigned
Labels
changelog/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import datadog_logs_custom_pipeline containing a lookup_processor
4 participants
@nkzou @skarimo @vinckama @rtrieu