Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_ip_ranges] Adds orchestrator to the resource #1781

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Feb 16, 2023

Summary

Motivation

Q&A

"Manual" self-testing

  1. make update-go-client to pull the latest Go client
  2. make build using my branch tbavelier/add_orchestrator_ip_ranges
  3. Use compiled binary in ~/.terraformrc :
provider_installation { 
  dev_overrides {
     "DataDog/datadog" = "~/go/bin"
   }

   # For all other providers, install them directly from their origin provider
   # registries as normal. If you omit this, Terraform will _only_ use
   # the dev_overrides block, and so no other providers will be available.
   direct {}
 }
  1. US1 :

Image 2023-02-16 at 2 22 53 PM

  1. US5 :

Image 2023-02-16 at 2 28 47 PM

@tbavelier tbavelier requested review from a team as code owners February 16, 2023 13:33
@tbavelier tbavelier changed the title Adds orchestrator to the datadog_ip_ranges resource [datadog_ip_ranges] Adds orchestrator to the resource Feb 16, 2023
@tbavelier tbavelier requested a review from a team as a code owner February 16, 2023 14:58
@tbavelier tbavelier removed the do-not-merge/WIP Do not merge this PR label Feb 16, 2023
@skarimo skarimo merged commit 95d8bf1 into master Feb 17, 2023
@skarimo skarimo deleted the tbavelier/add_orchestrator_ip_ranges branch February 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants