Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics] Add TOTP Parameters for Global Variables #1708

Merged
merged 13 commits into from
Jan 17, 2023

Conversation

thestefanristovski
Copy link
Contributor

@thestefanristovski thestefanristovski commented Jan 9, 2023

This PR updates Synthetics global variables to add MFA options and TOTP parameters.

SYNTH-511
SYNTH-841

@thestefanristovski thestefanristovski marked this pull request as ready for review January 12, 2023 13:35
@thestefanristovski thestefanristovski requested review from a team as code owners January 12, 2023 13:35
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion!

docs/resources/synthetics_global_variable.md Outdated Show resolved Hide resolved
@thestefanristovski thestefanristovski changed the title Synthetics Global Variables add TOTP [datadog_synthetics] Add TOTP Parameters for Global Variables Jan 12, 2023
maycmlee
maycmlee previously approved these changes Jan 12, 2023
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@skarimo skarimo merged commit 691e0a7 into master Jan 17, 2023
@skarimo skarimo deleted the stefan.ristovski/totp-digits branch January 17, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants