Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Add secure field to synthetics config variable #1696

Merged
merged 8 commits into from
Jan 5, 2023

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Jan 3, 2023

SSIA, resolves #1585

Note - since the backend no longer returns the secure variable, setting secure = true will result in drift if the variable pattern/example are updated elsewhere (via curl, API client, or web app).

@nkzou nkzou requested review from a team as code owners January 3, 2023 17:06
kayayarai
kayayarai previously approved these changes Jan 3, 2023
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit, and 👍 from docs

docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
Copy link
Member

@romainberger romainberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Synthetics

@nkzou nkzou requested a review from skarimo January 4, 2023 17:12
@nkzou nkzou merged commit 8931776 into master Jan 5, 2023
@nkzou nkzou deleted the kevinzou/synthetics_local_var_secure_field branch January 5, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for datadog_synthetics_test secure config_variables
4 participants