-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Synthetics Tests #169
Support Synthetics Tests #169
Conversation
Let's update the API Go Client upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks real good, I just have couple minor notes inline that should be addressed/answered. Please also consider squashing the commits. Thanks!
The create/edit web services now accept the status
LGTM 👍. Code is ok, acceptance tests are green and some hand testing with TF also looks good. (I don't have rights to merge though, so someone else needs to push the button) |
…urces Support Synthetics Tests
This PR will add support for CRUD operations on API Synthetics Tests.
We need to wait for this PR to be merged before merging this one.
TODO
Testing guidelines
Either run
make testacc
to run acceptance tests or try the CLI tool:With a basic
main.tf
terraform config file: