-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog_monitor] Add enable_samples monitor options #1670
[datadog_monitor] Add enable_samples monitor options #1670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to pull in the updated go client auto generated from the spec PR. Then we'll also need to set the value similar to
terraform-provider-datadog/datadog/resource_datadog_monitor.go
Lines 627 to 631 in efa529e
if attr, ok := d.GetOk("enable_logs_sample"); ok { | |
o.SetEnableLogsSample(attr.(bool)) | |
} else { | |
o.SetEnableLogsSample(false) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@rtrieu please don't merge this, it isn't functional yet. Please wait for a member of the @DataDog/integrations-tools-and-libraries to approve. |
Recently we added samples for ci-tests and ci-pipeline monitors, which users can enable using
enable_samples
attribute.Adding
enable_samples
to monitor options spec and docs.