Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_monitor] Add enable_samples monitor options #1670

Merged
merged 7 commits into from
Dec 16, 2022

Conversation

liashenko
Copy link
Contributor

Recently we added samples for ci-tests and ci-pipeline monitors, which users can enable using enable_samples attribute.

Adding enable_samples to monitor options spec and docs.

@liashenko liashenko requested review from a team as code owners December 13, 2022 12:43
@liashenko liashenko changed the title Add enable_samples monitor options [monitor] Add enable_samples monitor options Dec 13, 2022
Copy link
Contributor

@phillip-dd phillip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to pull in the updated go client auto generated from the spec PR. Then we'll also need to set the value similar to

if attr, ok := d.GetOk("enable_logs_sample"); ok {
o.SetEnableLogsSample(attr.(bool))
} else {
o.SetEnableLogsSample(false)
}

rtrieu
rtrieu previously approved these changes Dec 13, 2022
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rtrieu rtrieu enabled auto-merge (squash) December 13, 2022 21:23
@phillip-dd
Copy link
Contributor

@rtrieu please don't merge this, it isn't functional yet. Please wait for a member of the @DataDog/integrations-tools-and-libraries to approve.

@phillip-dd phillip-dd disabled auto-merge December 13, 2022 21:48
@therve therve changed the title [monitor] Add enable_samples monitor options [datadog_monitor] Add enable_samples monitor options Dec 16, 2022
@therve therve merged commit 78b432e into master Dec 16, 2022
@therve therve deleted the andrii.liashenko/add_enable_samples_monitor_option branch December 16, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants