Add monitor_tags getting and setting to downtime resource #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@lampad zorkian/go-datadog-api#227 has been merged, so feel free to get this tested and moving |
lampad
force-pushed
the
add_downtime_monitor_tags
branch
3 times, most recently
from
b6c46a5 to
f26c945
Compare
lampad
force-pushed
the
add_downtime_monitor_tags
branch
from
2835db8 to
85359ce
Compare
|
Alright @vanvlack looks like we're green here. Let me know if I need to update anything, or if I did anything dumb! |
|
@lampad yay! hoping a repo owner can look at getting this merged. |
lampad
force-pushed
the
add_downtime_monitor_tags
branch
from
85359ce to
74b24b9
Compare
|
@bkabrda no problem. Good to go! |
|
Perfect, thanks 👍 I'm merging this. |
|
This feature is missing documentation as far as I can see (v1.9.0). |
|
@jrehwaldt you're right, thanks for letting us know. I'll draft a PR for the docs update later today. |
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
Add monitor_tags getting and setting to downtime resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add monitor tags to the downtime resource to address https://github.com/terraform-providers/terraform-provider-datadog/issues/162.
My first real foray into go and terraform, so let me know if I did anything wrong. Mostly copied a bunch of stuff.
The tests pass locally, but I refrained from running the acceptance tests locally because of the note mentioning that it costs money to run them. I'm hoping CI will catch any issues there.
However, things are gonna fail until zorkian/go-datadog-api#227 gets merged in.