[datadog_security_monitoring_rule] Updating schema validation for field type #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-elias
force-pushed
the
elias.croze/sec-5988
branch
from
4c413b1 to
d8eeebc
Compare
symphony-elias
changed the title
symphony-elias
force-pushed
the
elias.croze/sec-5988
branch
from
3846b12 to
048a207
Compare
symphony-elias
force-pushed
the
elias.croze/sec-5988
branch
from
048a207 to
19deb61
Compare
roughbits01
approved these changes
Nov 16, 2022
symphony-elias
commented
Nov 17, 2022
| Description: "The rule type.", | ||
| Default: "log_detection", | ||
| Type: schema.TypeString, | ||
| ValidateDiagFunc: validators.ValidateStringEnumValue(datadogV2.SECURITYMONITORINGRULETYPEREAD_LOG_DETECTION, |
There was a problem hiding this comment.
I didn't reuse OOTB validator provided by the TF SDK because:
- documentation is generated by checking the output of the ValidateDiagFunc when passing an
EnumChecker - PR build fails when manually updating the documentation
There was a problem hiding this comment.
therve
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to explicitly remove support for
infrastructure_configurationandcloud_configurationrules as their management with TF is broken. See RFC for more details.