[datadog_synthetics] Add body_type field to SyntheticsTest request_definition #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work without a pr in https://github.com/DataDog/datadog-api-spec/blob/master/spec/v1/synthetics.yaml to add body type. I'm working on this ATM. After the PR on api-spec, we will need to update the go client used by the TF provider. |
|
I have a PR open on api-spec with the spec addition https://github.com/DataDog/datadog-api-spec/pull/1922/, asked for a review on it last week. Do you want to supersede it with your own PR? Edit: closed the linked PR, made a fix for the new one in api-spec |
This was
linked to
issues
Nov 9, 2022
nkzou
changed the title
nkzou
changed the title
skarimo
approved these changes
Nov 10, 2022
skarimo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this PR updates the Go client dependency, and converts all tests'
restricted_rolesfields to use uuids instead of role names