Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_security_monitoring_rules] Deprecate metric field of Security Monitoring Rules #1604

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[datadog_security_monitoring_rules] Deprecate metric field of Security Monitoring Rules #1604

merged 2 commits into from
Oct 24, 2022

Conversation

clementgbcn
Copy link
Contributor

The new field metrics have been introduced in Datadog backend. Since it is a list of metrics, the field metric could be merged into the metrics field as a list of one element. Therefore, this field is doomed to disappear.

In order to prepare the removal of this field, this PR add a Deprecated tag to the metric field to warm Terraform users.

@clementgbcn clementgbcn requested review from a team as code owners October 19, 2022 12:13
@clementgbcn clementgbcn force-pushed the cgc/SEC-5364-deprecate-metric branch from fe1186b to 6ec1895 Compare October 19, 2022 12:13
@clementgbcn clementgbcn marked this pull request as draft October 19, 2022 13:47
@clementgbcn clementgbcn force-pushed the cgc/SEC-5364-deprecate-metric branch from 6ec1895 to b009584 Compare October 24, 2022 08:52
@clementgbcn clementgbcn force-pushed the cgc/SEC-5364-deprecate-metric branch from b009584 to 323d910 Compare October 24, 2022 08:56
@clementgbcn clementgbcn marked this pull request as ready for review October 24, 2022 08:56
pietrodll
pietrodll approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@pietrodll pietrodll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@skarimo skarimo changed the title [SEC-5364] Deprecate metric field of Security Monitoring Rules Deprecate metric field of Security Monitoring Rules Oct 24, 2022
@skarimo skarimo changed the title Deprecate metric field of Security Monitoring Rules [datadog_security_monitoring_rules] Deprecate metric field of Security Monitoring Rules Oct 24, 2022
@skarimo skarimo merged commit 4518e5c into master Oct 24, 2022
@skarimo skarimo deleted the cgc/SEC-5364-deprecate-metric branch October 24, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

@pietrodll pietrodll pietrodll approved these changes

Assignees
No one assigned
Labels
changelog/note resource/datadog_security_monitoring_rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clementgbcn @pietrodll @skarimo