Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_rum_application] Add RUM Application resource support #1537

Merged
merged 11 commits into from
Aug 24, 2022

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Aug 23, 2022

Continues #1526 , adds cassettes and some doc improvements

@nkzou nkzou requested a review from a team August 23, 2022 19:23
benoitmeriaux
benoitmeriaux previously approved these changes Aug 24, 2022
@benoitmeriaux
Copy link
Member

I'm not very familiar with terraform provider, but it looks good :)

datadog/resource_datadog_rum_application.go Outdated Show resolved Hide resolved
datadog/resource_datadog_rum_application.go Show resolved Hide resolved
datadog/resource_datadog_rum_application.go Outdated Show resolved Hide resolved
datadog/resource_datadog_rum_application.go Outdated Show resolved Hide resolved
datadog/resource_datadog_rum_application.go Outdated Show resolved Hide resolved
datadog/resource_datadog_rum_application.go Outdated Show resolved Hide resolved
@nkzou nkzou merged commit f50480c into master Aug 24, 2022
@nkzou nkzou deleted the kevinzou/rum_application_support branch August 24, 2022 14:34
Copy link
Contributor

@buranmert buranmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing this 🙇

i left a comment regarding the potential confusion around "RUM Application ID" vs "Client Token"

datadog/resource_datadog_rum_application.go Show resolved Hide resolved

### Read-Only

- `client_token` (String) The RUM application client token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `client_token` (String) The RUM application client token
- `client_token` (String) The client token

@therve therve changed the title [RUM] Adds RUM Application resource support [datadog_rum_application] Adds RUM Application resource support Aug 25, 2022
@therve therve changed the title [datadog_rum_application] Adds RUM Application resource support [datadog_rum_application] Add RUM Application resource support Aug 25, 2022
@SebastianBalle
Copy link

@nkzou is it possible for you to implement the data resource for the rum_application? We share a single RUM application in multiple environments but manages the rum application resource in one. We would however like to know the client_token and id in other environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants