Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_monitor] Suppress diff when using ok and unknown thresholds in non service check monitors. #1529

Merged
merged 4 commits into from
Aug 22, 2022
Merged

[datadog_monitor] Suppress diff when using ok and unknown thresholds in non service check monitors. #1529

merged 4 commits into from
Aug 22, 2022

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Aug 16, 2022 •
edited
Loading

Closes #1418

@skarimo skarimo requested review from a team as code owners August 16, 2022 18:52
@skarimo skarimo changed the title Suppress diff when using ok and unknown thresholds in non service check monitors. [datadog_monitor] Suppress diff when using ok and unknown thresholds in non service check monitors. Aug 16, 2022
unclebconnor
unclebconnor previously approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@unclebconnor unclebconnor left a comment •
edited by skarimo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, pointing to the related validation in backend to confirm this is the correct behavior:

@skarimo skarimo merged commit 5a0d657 into master Aug 22, 2022
@skarimo skarimo deleted the sherz/fix-monitor-threshold-diff branch August 22, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@therve therve therve approved these changes

@unclebconnor unclebconnor unclebconnor left review comments

Assignees
No one assigned
Labels
changelog/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datadog_monitor resource "event-v2 alert" Ignore monitor_thresholds { ok = 0 }
4 participants
@skarimo @therve @hestonhoffman @unclebconnor