Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_security_monitoring_rule] Check for nil metrics values. #1506

Merged
merged 3 commits into from
Jul 27, 2022
Merged

[datadog_security_monitoring_rule] Check for nil metrics values. #1506

merged 3 commits into from
Jul 27, 2022

Conversation

juliendoutre
Copy link
Contributor

@juliendoutre juliendoutre commented Jul 27, 2022 •
edited
Loading

What does this PR do?

  • Fix a bug leading to an invalid type casting for this field (metrics can be set to nil leading to issues whenever trying to cast it to a string array)
  • Makes its values either set explicitly by the user, or computed by the API's backend

adriacabeza
adriacabeza previously approved these changes Jul 27, 2022
View reviewed changes
@juliendoutre juliendoutre marked this pull request as ready for review July 27, 2022 12:06
@juliendoutre juliendoutre requested review from a team as code owners July 27, 2022 12:06
@juliendoutre juliendoutre requested a review from MatiasDwek July 27, 2022 12:06
muffix
muffix previously approved these changes Jul 27, 2022
View reviewed changes
clementgbcn
clementgbcn previously approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@clementgbcn clementgbcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@juliendoutre juliendoutre changed the title [Cloud SIEM] Check for nil metrics values in the Security Monitoring resource. [datadog_security_monitoring_rule] Check for nil metrics values in the Security Monitoring resource. Jul 27, 2022
@juliendoutre juliendoutre changed the title [datadog_security_monitoring_rule] Check for nil metrics values in the Security Monitoring resource. [datadog_security_monitoring_rule] Check for nil metrics values. Jul 27, 2022
@juliendoutre juliendoutre dismissed stale reviews from clementgbcn and muffix via 0b96cbe July 27, 2022 13:11
@skarimo skarimo merged commit 22c49cd into master Jul 27, 2022
@skarimo skarimo deleted the julien.doutre/metrics-field-casting-fix branch July 27, 2022 18:08
@sdinay sdinay mentioned this pull request Sep 8, 2022
Closed
This was referenced Nov 1, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

@adriacabeza adriacabeza adriacabeza approved these changes

@clementgbcn clementgbcn clementgbcn left review comments

@muffix muffix muffix left review comments

@MatiasDwek MatiasDwek Awaiting requested review from MatiasDwek MatiasDwek is a code owner automatically assigned from DataDog/k9-cloud-security-platform

Assignees
No one assigned
Labels
changelog/bugfix ci/integrations resource/datadog_security_monitoring_rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliendoutre @muffix @adriacabeza @skarimo @clementgbcn