Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_security_monitoring_rule] NewValue detection type supports threshold learning duration and metrics #1479

Merged
merged 16 commits into from
Jul 22, 2022
Merged

[datadog_security_monitoring_rule] NewValue detection type supports threshold learning duration and metrics #1479

merged 16 commits into from
Jul 22, 2022

Conversation

juliendoutre
Copy link
Contributor

@juliendoutre juliendoutre commented Jul 1, 2022 •
edited
Loading

What does this PR do?

Update the NewValue options to support recent updates in the API.

Update process

  1. I ran go get -u github.com/DataDog/datadog-api-client-go@master to update the Datadog Go client to a version supporting the new fields.
  2. I updated the resource definition mapping and the tests.
  3. I updated this resource's cassettes by running RECORD=true TESTARGS="-run <TEST_FUNCTION>" make testacc for all relevant test functions in https://github.com/DataDog/terraform-provider-datadog/blob/master/datadog/tests/resource_datadog_security_monitoring_rule_test.go.
  4. I updated the documentation by running make doc.

@juliendoutre juliendoutre changed the title [CloudSIEM] NewValue detection type supports threshold learning duration [CloudSIEM] NewValue detection type supports threshold learning duration and metrics Jul 20, 2022
@juliendoutre juliendoutre marked this pull request as ready for review July 20, 2022 13:23
@juliendoutre juliendoutre requested review from a team as code owners July 20, 2022 13:23
@juliendoutre juliendoutre requested a review from k3nz0 July 20, 2022 13:23
adriacabeza
adriacabeza previously approved these changes Jul 20, 2022
View reviewed changes
Copy link

@adriacabeza adriacabeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

buraizu
buraizu reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor update per our contributing guidelines

docs/resources/security_monitoring_rule.md Outdated Show resolved Hide resolved
@skarimo skarimo changed the title [CloudSIEM] NewValue detection type supports threshold learning duration and metrics [datadog_security_monitoring_rule] NewValue detection type supports threshold learning duration and metrics Jul 21, 2022
@skarimo skarimo merged commit 396bd0f into master Jul 22, 2022
@skarimo skarimo deleted the julien.doutre/new-values-learning-method branch July 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

@buraizu buraizu buraizu approved these changes

@adriacabeza adriacabeza adriacabeza left review comments

@k3nz0 k3nz0 Awaiting requested review from k3nz0 k3nz0 is a code owner automatically assigned from DataDog/k9-cloud-security-platform

Assignees
No one assigned
Labels
changelog/feature ci/integrations resource/datadog_security_monitoring_rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliendoutre @adriacabeza @buraizu @skarimo