Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fill_min and fill_max panic issue #144

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Fix fill_min and fill_max panic issue #144

merged 1 commit into from
Jan 14, 2019

Conversation

dabcoder
Copy link
Contributor

Without this running terraform apply would result in a panic:

panic: interface conversion: interface {} is string, not float64
[...]
...datadog.setJSONNumberFromDict...

@ghost ghost added the size/XS label Jan 11, 2019
gzussa
gzussa approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci added this to the 1.7.0 milestone Jan 14, 2019
@masci masci merged commit 3841200 into DataDog:master Jan 14, 2019
jbenais pushed a commit to jbenais/terraform-provider-datadog that referenced this pull request Aug 20, 2019
@masci
Merge pull request DataDog#144 from dabcoder/davidb/go-api-client-typ…
4bfaeab 
…e-update-widgets

Fix fill_min and fill_max panic issue
@dabcoder dabcoder deleted the davidb/go-api-client-type-update-widgets branch August 27, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabcoder @gzussa @masci