[datadog_synthetics_test] [datadog_synthetics_private_location] Add support for restricted roles on private locations and synthetics tests #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajofo
force-pushed
the
david.forsythe/SYA-1526/update-tests-for-restricted-roles
branch
from
6a94f99 to
1850a94
Compare
AlaricCalmette
previously approved these changes
Apr 28, 2022
AlaricCalmette
changed the title
AlaricCalmette
changed the title
alai97
previously approved these changes
Apr 28, 2022
| @@ -30,13 +30,21 @@ resource "datadog_synthetics_private_location" "private_location" { | |||
| ### Optional | |||
|
|
|||
| - **description** (String) Description of the private location. | |||
| - **metadata** (Block List, Max: 1) The private location metadata (see [below for nested schema](#nestedblock--metadata)) | |||
There was a problem hiding this comment.
Suggested change
| - **metadata** (Block List, Max: 1) The private location metadata (see [below for nested schema](#nestedblock--metadata)) | |
| - **metadata** (Block List, Max: 1) The private location metadata. See [nested schema](#nestedblock--metadata) below. |
There was a problem hiding this comment.
I don't think we'll be able to change this wording because it's auto-generated. See synthetics_test.md for many examples of this exact phrasing.
skarimo
reviewed
Apr 29, 2022
datadog/tests/resource_datadog_synthetics_private_location_test.go
Outdated
Show resolved
Hide resolved
skarimo
reviewed
Apr 29, 2022
dajofo
force-pushed
the
david.forsythe/SYA-1526/update-tests-for-restricted-roles
branch
4 times, most recently
from
e3b0767 to
af7a53d
Compare
therve
force-pushed
the
david.forsythe/SYA-1526/update-tests-for-restricted-roles
branch
from
42ed6ab to
7b337a0
Compare
therve
approved these changes
May 4, 2022
therve
deleted the
david.forsythe/SYA-1526/update-tests-for-restricted-roles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update synthetic tests for restricted roles options